----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27923/#review62051 -----------------------------------------------------------
I don't think you looked over your diff before you published.. ;) - Ben Mahler On Nov. 18, 2014, 8 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27923/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 8 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1718 > https://issues.apache.org/jira/browse/MESOS-1718 > > > Repository: mesos-git > > > Description > ------- > > Use Slave::getExecutorInfo() only once. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 85170a11f049cda92840c52dc5acf447ca0a50fb > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 8e51957d141af0be64cac42f65e03bca5929c8a9 > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > 4f7153eb873e9b843fa6d8067bfbfcbf8932cb40 > 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp > cf354125687e0f60b6d5b105f19d75e4436f21bf > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/include/process/c++11/delay.hpp > 5818e83435ec519c50d5b4e86363f772e03733f4 > 3rdparty/libprocess/include/process/clock.hpp > 1fd418b31133fd5a5444095ac887c77ee9375b2d > 3rdparty/libprocess/include/process/delay.hpp > 40627ea560ed7af1d04c10f497cf777ac9fd1c67 > 3rdparty/libprocess/include/process/future.hpp > 2e4f9efe53e2e9966f23bd516e61fd9d83ed6b33 > 3rdparty/libprocess/include/process/node.hpp > 24132a5a9ff36a0fff3a25e7f7efce23777e3833 > 3rdparty/libprocess/include/process/pid.hpp > 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 > 3rdparty/libprocess/include/process/process.hpp > cb3e0a652b96ac8dfc37193a5c0702b8f3c6a613 > 3rdparty/libprocess/include/process/socket.hpp > 20136ba4c65883b8bbcc8498e09f7ff7b50b68a4 > 3rdparty/libprocess/include/process/timeout.hpp > 5c46d70a492f5fd2277913f4da8c099c164a1f9c > 3rdparty/libprocess/include/process/timer.hpp > e5d71f6dc7727cc22244d5cec46cddd9e338a650 > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 > 251213a7e5e57da4b367f033865594b3678d53aa > 3rdparty/libprocess/src/clock.cpp 5623b58cff68c5faf62c7d3fe121a0bbb1b40d94 > 3rdparty/libprocess/src/encoder.hpp > 2b0d83f721814931adc4f7717b755fa08dcd416d > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > 3rdparty/libprocess/src/io.cpp 75fe75cfb00e0dc9d1dadea4fc6d6b9aea450fcb > 3rdparty/libprocess/src/libev.hpp 04847e30b0d764d258b8c0971da87180043161f2 > 3rdparty/libprocess/src/libev.cpp 6560050bfc17752236bef3540b29d280898f1953 > 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078 > 3rdparty/libprocess/src/poll.cpp 324e4dd950989f3717ca73fe48520ca3e518518f > 3rdparty/libprocess/src/process.cpp > 404a32dae1b3d22cb55dcbd084623d6b0cb82c71 > 3rdparty/libprocess/src/tests/benchmarks.cpp > 227b8e7ae5f855918073b7b3ea89d773a39aa8fa > 3rdparty/libprocess/src/tests/http_tests.cpp > a90e65f77904da0a45e1cc0cc9889ae69354a1a5 > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 0c80c69bc3457fd70ab745ff8a02be6ec9cfd9e7 > 3rdparty/libprocess/src/tests/process_tests.cpp > 902d4d329abde442d9a3a2ffd52408b80dd45c80 > CHANGELOG a10c5ede940c04a723e10f52392cc05d081fc22a > docs/upgrades.md 51c7e70c7ddcd3d5f678872553a18eb27622f052 > m4/ax_cxx_compile_stdcxx_11.m4 6a859b89953df2132a75f61833d5d3316968ec99 > src/Makefile.am 0fe7dd067b80cfe802201482eed63a30ac8dcbd4 > src/authentication/authenticatee.hpp > 361083b5e1ca5ab1a594b3108fb768626313a725 > src/authentication/cram_md5/authenticatee.hpp > 5d35598f75f4d9a8c185cfd387e1085b3bf15395 > src/authentication/cram_md5/authenticator.hpp > d739a02d755c2729248291db8c274ad7e7dd4c6d > src/common/protobuf_utils.cpp e3e430d321ef472705b8a6218c761ac6cb5f4ba6 > src/docker/docker.hpp f004879cab8524a5c765a42a2216f22e2e9a1f0a > src/docker/docker.cpp f2730a733fbabea90e9395de85c0668a29ccc530 > src/examples/test_authentication_modules.cpp > 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65 > src/launcher/executor.cpp 6175bf54d09268feb2007ca5384643adfa00456b > src/launcher/fetcher.cpp 1dd39b1c8270ca4af6c7425fb3c033e580f403a7 > src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 > src/master/master.hpp ece36c3cd7b4f722527bbcd40c29a58a3a3390ec > src/master/master.cpp b5fa8d19f031892922e4507f51280c83aa3e4a1a > src/master/metrics.hpp 5e6b6d55ce03727f25140379c15d08bd5d70df38 > src/master/metrics.cpp a7ac96d34bbd84b5df74e1434624340d55b8651a > src/messages/messages.proto 566ce536400501f5838dc7cb3534b5ee3f0d0a89 > src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2 > src/module/manager.cpp b15b0fc3f056fe29bd4d1acca508d75805ef2e0b > src/sched/constants.hpp ac497b2abc9fbeab713b312cf37963d7de28ed50 > src/sched/constants.cpp 517ca5cb0dad49d775d65c9ffabc849ff85347a0 > src/sched/flags.hpp 4e0d56f61b6877254161112b288ae4a9c579e846 > src/sched/sched.cpp 0b08512d1b33857be89246d197184b0cc98e0540 > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > src/slave/constants.hpp fd1c1aba0aa62372ab399bee5709ce81b8e92cec > src/slave/constants.cpp 2a99b1105af0e2d62b956fa96988f477937a46bd > src/slave/containerizer/docker.cpp 8351ee30fcaf4afa11a9280e8819c2ad3e1c0142 > src/slave/containerizer/fetcher.cpp > 8dbc18d82f5c11ae7b1ba0e1d5db114045ee25fe > src/slave/flags.hpp fee79e04cca14e136241af06af1fa9105a70b6dd > src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a > src/slave/http.cpp d1cf8a68fab9a2df44f6c753683ad37fd4b1a1f9 > src/slave/slave.hpp 29bea655a4ba8c99b3a81108b9224b8476927761 > src/slave/slave.cpp 06b2e18ff9b202c30f8bf4378cdd35aef734337f > src/tests/cram_md5_authentication_tests.cpp > a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736 > src/tests/docker_containerizer_tests.cpp > 59c2beb1907b4c6b5782b7c848c5c5116b9de272 > src/tests/docker_tests.cpp ef0582808be246ca87f5d294cee67e72ee999208 > src/tests/fetcher_tests.cpp a21c98a09bcb457801990f824aa353e939cabe4d > src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e > src/tests/gc_tests.cpp 8618ae12b337bea19a82dec52455cd19cc735d89 > src/tests/logging_tests.cpp 22a785e80304415ff2aacf76972fd58c74eb5c15 > src/tests/master_contender_detector_tests.cpp > d847a30d21b2a2980c6b7ceb62bbf61dc77487de > src/tests/master_tests.cpp 66423a9dd1bc441ad7207830a87ddff220df2031 > src/tests/mesos.hpp c1d64a73ff2312a10d4e809072d219e60c28a76f > src/tests/mesos.cpp 3b98c69a604132be71a60fbbee4a47b51fe6956a > src/tests/metrics_tests.cpp 72571f2d71cd2f66381a50bc6a661e91e431f124 > src/tests/module.hpp bc1a37df7f95e945363418429fef4d090907c73a > src/tests/module.cpp 6cec1cbafe4750cff005191c51ce7c08149c18f4 > src/tests/monitor_tests.cpp 3b0261946405f9926742a680309880fac7480732 > src/tests/resource_offers_tests.cpp > 43820b0a709b6e8643940b70183e277000d4ba35 > src/tests/scheduler_tests.cpp e998217f419caa7f1f94df4c45d1cb562b0f8b0b > src/tests/slave_tests.cpp 18ff8fe499943d209549d9924558d6e84ce78fec > src/zookeeper/group.cpp 173caa859d8566318a1a832a8b763405ce41afc1 > > Diff: https://reviews.apache.org/r/27923/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
