----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28196/#review62117 -----------------------------------------------------------
Patch looks great! Reviews applied: [28195, 28196] All tests passed. - Mesos ReviewBot On Nov. 19, 2014, 12:06 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28196/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 12:06 a.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, Niklas Nielsen, > and Timothy Chen. > > > Bugs: MESOS-2126 > https://issues.apache.org/jira/browse/MESOS-2126 > > > Repository: mesos-git > > > Description > ------- > > Use std::vector instead of std::queue to reduce dynamic allocations and > improve performance. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 2e4f9efe53e2e9966f23bd516e61fd9d83ed6b33 > > Diff: https://reviews.apache.org/r/28196/diff/ > > > Testing > ------- > > make check > valgrind 3rdparty/libprocess > (previous) total heap usage: 272,452 allocs, 271,410 frees, 56,981,783 bytes > allocated > (new) total heap usage: 188,837 allocs, 188,111 frees, 28,694,829 bytes > allocated > 3rdparty/libprocess/benchmarks throughput improved ~78% > > > Thanks, > > Joris Van Remoortere > >
