> On Nov. 19, 2014, 4:42 p.m., Niklas Nielsen wrote: > > support/post-reviews.py, line 220 > > <https://reviews.apache.org/r/28205/diff/1/?file=768403#file768403line220> > > > > Won't this be a problem for folks where 'diff' isn't added to the url > > i.e. the trailing slash will be left in, in that case?
>From my understanding strip doesn't do a full match: "The chars argument is not a prefix or suffix; rather, all combinations of its values are stripped" (https://docs.python.org/2/library/stdtypes.html) However; I agree that it can be hard to read so I updated the review with an explicit replace. I'm also not too familiar with this script, so I might be missing something about what other inputs might be fed to this :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62158 ----------------------------------------------------------- On Nov. 19, 2014, 5:22 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28205/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 5:22 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > support/post-reviews.py 33c95fad1089286442010f37d1edea5434a0a7a6 > > Diff: https://reviews.apache.org/r/28205/diff/ > > > Testing > ------- > > Submitted this review using post-review. > Commit message review line: > Review: https://reviews.apache.org/r/28205 > > > Thanks, > > Joris Van Remoortere > >
