> On Nov. 19, 2014, 8:29 p.m., Cody Maloney wrote: > > In the longer run we will want to not inherit from unordered_map to > > make hashmap so we don't have to forward most of it's functonality. > > Rather, we should define helper functions which take a hashmap. It's > > far more maintainable and works better across a range of STL versions. > > Dominic Hamon wrote: > you mean helper functions that take an unordered_map, right? > > I started a patch to do this but I couldn't keep it rebased. It's not a > big change to deprecate hashmap. > > hint hint.
Yes, or generic functions that operate on the different classes of STL containers. We have the same general helpers for hashmap as we would like to have for std::map (and implement some on JSON::Object). - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28252/#review62217 ----------------------------------------------------------- On Nov. 19, 2014, 8:29 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28252/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 8:29 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2132 > https://issues.apache.org/jira/browse/MESOS-2132 > > > Repository: mesos-git > > > Description > ------- > > Simplified signature from the C++11 standard specification. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp > aa4d9ba68a27c1a7dea8cfe948a90487c4708add > 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp > eb3abfc9ba62f92d2ed5bc0e1c093791003a8319 > > Diff: https://reviews.apache.org/r/28252/diff/ > > > Testing > ------- > > make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
