> On Nov. 19, 2014, 8:51 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/http.hpp, line 341 > > <https://reviews.apache.org/r/28254/diff/1/?file=770213#file770213line341> > > > > would you consider moving some of these to the .cpp?
Definitely would be reasonable for someone to do. Here I'm just fixing the right angle brackets that would stay in the header as well file anyways. - Cody ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28254/#review62223 ----------------------------------------------------------- On Nov. 19, 2014, 8:30 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28254/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 8:30 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-2132 > https://issues.apache.org/jira/browse/MESOS-2132 > > > Repository: mesos-git > > > Description > ------- > > http: Allow sending Request objects > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 9cf05acbb724ab9af8010d1788621d37a0e48e86 > 3rdparty/libprocess/src/http.cpp b00f33339366f5c06b6f20e38c5ae0c23b8a9358 > > Diff: https://reviews.apache.org/r/28254/diff/ > > > Testing > ------- > > make distcheck ubuntu 14.04 > > > Thanks, > > Cody Maloney > >
