-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27606/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 12:34 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Address reviewer comments
Bugs: mesos-1877
https://issues.apache.org/jira/browse/mesos-1877
Repository: mesos-git
Description
-------
Files attach, detach, and browse now all call a single function to standardize
the path. Before attach, browse did the normalization. Detach did not.
Switch to strings::tokenize() for splitting apart the path into tokens, as that
is more canonical across the codebase, used by libprocess for proccessing paths.
Update detach to return a bool of whether or not the detach does anything which
means that it can be tested.
Add some additional testing to catch the inconsistencies in path handlign
between attach and detach previously, some of the oddness in current path
handling so that they can be explicitly seen when changes happen.
Diffs (updated)
-----
src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9
src/files/files.cpp 12e8f75aa7bd77d2e81d5d3a7a4d09dd915854aa
src/tests/files_tests.cpp 9ad6db51873b96b3cd759523cef9748f6823fb7e
Diff: https://reviews.apache.org/r/27606/diff/
Testing
-------
make distcheck on ubuntu 14.04
Thanks,
Cody Maloney
