----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28065/#review62291 -----------------------------------------------------------
src/Makefile.am <https://reviews.apache.org/r/28065/#comment104319> s/grace/graceful/? If so, then do a scan over the files. src/slave/constants.hpp <https://reviews.apache.org/r/28065/#comment104320> Sweet comment! The timeout isn't for the task, right? Only for the executor - so we need to remove '[Task]' from the nest diagram, no? src/slave/constants.hpp <https://reviews.apache.org/r/28065/#comment104438> We need to think in general terms; the command executor is just one we provide. src/slave/grace_shutdown.hpp <https://reviews.apache.org/r/28065/#comment104436> The last part can be any executor, right? (CommandExecutor being one that adheres to the timeout/escalation)? src/slave/grace_shutdown.hpp <https://reviews.apache.org/r/28065/#comment104437> /<-- shutdown_grace_period/<-- shutdown_grace_period./ src/slave/grace_shutdown.cpp <https://reviews.apache.org/r/28065/#comment104429> s/ )/)/ src/slave/grace_shutdown.cpp <https://reviews.apache.org/r/28065/#comment104432> s/header/graceful_shutdown.hpp/ src/slave/grace_shutdown.cpp <https://reviews.apache.org/r/28065/#comment104427> Do you need 'mesos::internal::slave' when you are already in the namespace? Here and below (we may be able to get rid of some of the wrappings) src/slave/grace_shutdown.cpp <https://reviews.apache.org/r/28065/#comment104435> Executor vs CommandExecutor is confusing - do you mean ExecutorProcess vs Executor? src/slave/grace_shutdown.cpp <https://reviews.apache.org/r/28065/#comment104433> This is a noop right? Why not return baseShutdownTimeout immediately? - Niklas Nielsen On Nov. 17, 2014, 4:10 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28065/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 4:10 a.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Till Toenshoff. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > Shutdown grace period differs across shutdown levels (containerizer, > ExecutorProcess, CommandExecutor). Each nested timeout is somewhat shorter > than the parent one. > > > Diffs > ----- > > src/Makefile.am 0fe7dd0 > src/slave/constants.hpp fd1c1ab > src/slave/constants.cpp 2a99b11 > src/slave/grace_shutdown.hpp PRE-CREATION > src/slave/grace_shutdown.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28065/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
