> On Nov. 20, 2014, 8:36 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, line 2582 > > <https://reviews.apache.org/r/28293/diff/1/?file=771341#file771341line2582> > > > > Hm.. sharing the same key is allowed? What about same key, but with no > > values? > > > > e.g. > > > > key = "foo" > > key = "foo" > > > > Is that allowed? What would be the point of that? > > Niklas Nielsen wrote: > My first label patch was modeled as a dictionary (which prevented > duplicate keys). On Tim's suggestion, we changed it to an array of key value > pairs as it modeled the protobuf more precisely (the user is not prevented > from setting duplicate keys/values).
Hi Ben, I think it's common enough to have labels that has the same key but multiple values, I think if the user supplies duplicate values we're not going to audit it for them. At one point we do want to start limiting the size too, and it's all up to the user to control. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28293/#review62411 ----------------------------------------------------------- On Nov. 20, 2014, 7:37 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28293/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2014, 7:37 p.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > See description. > > > Diffs > ----- > > src/tests/master_tests.cpp 21a642f2e001e13e3a8881803a5d0cdbee36dd67 > > Diff: https://reviews.apache.org/r/28293/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
