----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28257/#review62449 -----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp <https://reviews.apache.org/r/28257/#comment104491> 'prefix' is not very descriptive, and there's no sense of what i would use it for in the documentation for this method. Can you explain a bit about when it should be set to true? Would you consider adding prefix-specific overrides instead of a default arg bool? ie, routeWithPrefix(name, help, handler); - Dominic Hamon On Nov. 19, 2014, 4:26 p.m., Cody Maloney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28257/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 4:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Dominic Hamon, and Joris Van > Remoortere. > > > Bugs: MESOS-2130 > https://issues.apache.org/jira/browse/MESOS-2130 > > > Repository: mesos-git > > > Description > ------- > > Allow prefix paths in libprocess > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > 3708f98b8fb6737aafb1c058122a8cd01885b76d > 3rdparty/libprocess/src/process.cpp > 7a986d7defb03043ec70a48e161ede50deef9b26 > > Diff: https://reviews.apache.org/r/28257/diff/ > > > Testing > ------- > > make distcheck ubuntu 14.04 > > Manually browse the mesos web UI and verify that things seem to generally work > > > Thanks, > > Cody Maloney > >
