Or it is time to once again ask: must we continue to support a really old compiler? On Nov 21, 2014 5:22 PM, "Ian Downes" <[email protected]> wrote:
> Ideally, if we're going to continue supporting 4.4 we should get a CI box > with 4.4... > > On Fri, Nov 21, 2014 at 5:16 PM, Timothy Chen <[email protected]> wrote: > > > > > > > > On Nov. 22, 2014, 1:15 a.m., Timothy Chen wrote: > > > > Ship It! > > > > Interesting, I'll keep this in mind to try to find a gcc-4.4 compiler to > > verify patches. > > > > > > - Timothy > > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/28357/#review62702 > > ----------------------------------------------------------- > > > > > > On Nov. 22, 2014, 1:12 a.m., Jie Yu wrote: > > > > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > https://reviews.apache.org/r/28357/ > > > ----------------------------------------------------------- > > > > > > (Updated Nov. 22, 2014, 1:12 a.m.) > > > > > > > > > Review request for mesos, Ian Downes and Timothy Chen. > > > > > > > > > Repository: mesos-git > > > > > > > > > Description > > > ------- > > > > > > This regression is introduced by this patch: > > > https://reviews.apache.org/r/28141 > > > > > > Since Limitation is put in a vector now, the old std::vector impl. uses > > default assignment which does not work since Limitation has const > members. > > > > > > > > > Diffs > > > ----- > > > > > > src/slave/containerizer/isolator.hpp > > bdcf7a913d0fe24cbda5ec88c9af6802595f0296 > > > > > > Diff: https://reviews.apache.org/r/28357/diff/ > > > > > > > > > Testing > > > ------- > > > > > > make check > > > > > > > > > Thanks, > > > > > > Jie Yu > > > > > > > > > > >
