----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28362/#review62725 -----------------------------------------------------------
include/mesos/resources.hpp <https://reviews.apache.org/r/28362/#comment104801> Look like this fits in one line? include/mesos/resources.hpp <https://reviews.apache.org/r/28362/#comment104802> s/NOTEL/NOTE:/ src/common/resources.cpp <https://reviews.apache.org/r/28362/#comment104803> I am a little worried about the performance regression here because you are adding 'validate' to every contains check. I believe 'contains' check is pretty heavily used in master. Could you please have a private _contains function which does not do the validation and let the public 'contains' function call it? - Jie Yu On Nov. 22, 2014, 1:37 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28362/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2014, 1:37 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Needed this for my subsequent review. > > Also pulled up a private method for the same reason. > > > Diffs > ----- > > include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1 > src/common/resources.cpp 27c6240dd775eff3918f4771916cb9c0df94aba9 > > Diff: https://reviews.apache.org/r/28362/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
