----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28383/#review62795 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28383/#comment104914> stout can't include from process, sorry. either this moves to libprocess, or node moves to stout. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28383/#comment104915> given addr and other.addr may overlap, you should think about using memmove. 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp <https://reviews.apache.org/r/28383/#comment104916> CHECK that sin_family is AF_INET - Dominic Hamon On Nov. 23, 2014, 9:47 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28383/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 9:47 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1916 > https://issues.apache.org/jira/browse/MESOS-1916 > > > Repository: mesos-git > > > Description > ------- > > SockaddrStorage uses struct sockaddr_storage (a placeholder for sockaddr_in > and sockaddr_in6 structures) and is convenient for when you need a struct > sockaddr(eg: for bind, connect calls). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b > > Diff: https://reviews.apache.org/r/28383/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
