-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28385/#review62798
-----------------------------------------------------------



3rdparty/libprocess/src/net.hpp
<https://reviews.apache.org/r/28385/#comment104919>

    const process::Node& is a better idea.



3rdparty/libprocess/src/net.hpp
<https://reviews.apache.org/r/28385/#comment104921>

    explicit please, or you'll end up with accidental implicit conversions.


- Dominic Hamon


On Nov. 23, 2014, 9:48 p.m., Evelina Dumitrescu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28385/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2014, 9:48 p.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced the ip and port pairs from Server and ServerProcess classes with 
> Node class
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/net.hpp 7bf6085e1bd9ffa0e42a5da9c3567521ff4c0713 
> 
> Diff: https://reviews.apache.org/r/28385/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Evelina Dumitrescu
> 
>

Reply via email to