----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28388/#review62804 -----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp <https://reviews.apache.org/r/28388/#comment104938> const net::IPAddress& 3rdparty/libprocess/include/process/node.hpp <https://reviews.apache.org/r/28388/#comment104939> look how much cleaner that is! yay! 3rdparty/libprocess/src/pid.cpp <https://reviews.apache.org/r/28388/#comment104940> probably should be some way to set the ip address which checks the family of the incoming in_addr and sets the right fields appropriately. - Dominic Hamon On Nov. 23, 2014, 9:49 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28388/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2014, 9:49 p.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Create an IP address abstraction such that every callsite does not need to > check the family and get the right address. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/node.hpp > 24132a5a9ff36a0fff3a25e7f7efce23777e3833 > 3rdparty/libprocess/include/process/pid.hpp > 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22 > 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078 > 3rdparty/libprocess/src/process.cpp > cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14 > > Diff: https://reviews.apache.org/r/28388/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
