> On Nov. 23, 2014, 3:49 p.m., Benjamin Hindman wrote:
> > src/watcher/whitelist_watcher.hpp, lines 34-35
> > <https://reviews.apache.org/r/28230/diff/1/?file=769747#file769747line34>
> >
> > Why aren't you just using master/constants.hpp and then
> > WHITELIST_WATCH_INTERVAL? Otherwise, I'd expect that you're moving it here
> > but I didn't see that deleted in this review.
yeah - along the same lines: Can we make this a parameter instead and grab the
constants from src/{master,slave}/constants.{hpp,cpp} instead?
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28230/#review62745
-----------------------------------------------------------
On Nov. 20, 2014, 8:42 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28230/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 8:42 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen,
> and Vinod Kone.
>
>
> Bugs: MESOS-2114
> https://issues.apache.org/jira/browse/MESOS-2114
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> WhitelistWatcher can be used for tracking changes to all kind of whitelists.
> In order to reuse the functionality, extract the code from master sources.
>
>
> Diffs
> -----
>
> src/Makefile.am 0fe7dd0
> src/master/hierarchical_allocator_process.hpp 31dfb2c
> src/master/master.hpp ece36c3
> src/master/master.cpp 9e2d768
> src/watcher/whitelist_watcher.hpp PRE-CREATION
> src/watcher/whitelist_watcher.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28230/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.9.4, Ubuntu 14.04)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
