----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28365/#review63460 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/28365/#comment105718> move this to ResourceUsageChecker() add duplicate disk id check to Resources::validate() src/master/master.cpp <https://reviews.apache.org/r/28365/#comment105720> add a comment on why persistent resources cannot go empty or just always send it. src/master/master.cpp <https://reviews.apache.org/r/28365/#comment105721> always send it. src/slave/slave.cpp <https://reviews.apache.org/r/28365/#comment105715> just do a CHECK/EXIT instead. src/slave/slave.cpp <https://reviews.apache.org/r/28365/#comment105716> gc released resources. - Vinod Kone On Dec. 1, 2014, 6:25 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28365/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 6:25 p.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Added UpdatedResourcesMessage to inform slave about persistent resources. > > Slave informs about its persistent state during (re-)registration. > > > Diffs > ----- > > include/mesos/mesos.proto 0085aba923b53c37f31d5af30b2eeec5d533d8ba > include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1 > src/common/resources.cpp 535a0eab6377b9ae63c960cdb05978647f667d5e > src/master/master.hpp 79b9ba720f343f512748211dd41ea7a0cfcb0cfb > src/master/master.cpp 8fcda4b9b5857f14cff8f6af2de31cca0208b88d > src/messages/messages.proto 28e593f338a154892b1cdf398710bb44e3f9f119 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp ed63dedbda0bf548a95de7d39002ac56a29303e5 > > Diff: https://reviews.apache.org/r/28365/diff/ > > > Testing > ------- > > None. > > > Thanks, > > Vinod Kone > >
