> On Dec. 1, 2014, 7:02 p.m., Dominic Hamon wrote: > > src/slave/paths.hpp, line 99 > > <https://reviews.apache.org/r/28562/diff/1/?file=779092#file779092line99> > > > > are these constants needed outside of the below functions? if not, > > consider moving them into the functions to avoid the overhead in every file > > that includes this header. > > > > if they are, they shouldn't be string type as this is non-POD and > > initialization order is not guaranteed.
Yes, I agree with you, but I just want to be consistent with the rest of the file. We can do the refactor later. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28562/#review63410 ----------------------------------------------------------- On Dec. 1, 2014, 6:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28562/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 6:56 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos-git > > > Description > ------- > > Added a function to get persistent volume paths. > > > Diffs > ----- > > src/slave/paths.hpp ee8687d94f2907be0945762c68827f8cd0af6e4f > > Diff: https://reviews.apache.org/r/28562/diff/ > > > Testing > ------- > > Will be in subsequent patches. > > > Thanks, > > Jie Yu > >
