> On Sept. 7, 2014, 1:47 a.m., Tom Arnfeld wrote:
> > Dockerfile, line 32
> > <https://reviews.apache.org/r/25369/diff/1/?file=679166#file679166line32>
> >
> >     You can avoid these `cd /opt` commands by defining a `WORKDIR /opt` 
> > instruction before this line, every subsequent container will pick that up, 
> > so you can reduce a bit of code duplication :)

Gabriel are you still working on this patch?


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25369/#review52551
-----------------------------------------------------------


On Sept. 5, 2014, 12:50 a.m., Gabriel Monroy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25369/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 12:50 a.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add Dockerfile for building Mesos from source
> 
> 
> Diffs
> -----
> 
>   Dockerfile PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25369/diff/
> 
> 
> Testing
> -------
> 
> Create snapshot builds with: 
> docker build -t mesos/mesos:git-`git rev-parse --short HEAD` .
> 
> Run master/slave with:
> docker run mesos/mesos:git-`git rev-parse --short HEAD` mesos-master [options]
> docker run mesos/mesos:git-`git rev-parse --short HEAD` mesos-slave [options]
> 
> Some Docker layer gymanstics are performed during the final layer to remove 
> build dependencies and reduce image size from ~5GB to < 2GB.
> 
> 
> Thanks,
> 
> Gabriel Monroy
> 
>

Reply via email to