> On Dec. 3, 2014, 10:35 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 1938 > > <https://reviews.apache.org/r/28626/diff/2/?file=781896#file781896line1938> > > > > Do you need to validate the ID as well? Will it ultimately need to land > > as a directory name on the slave (i.e. no slashes, etc)?
Yes! Will include that. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28626/#review63766 ----------------------------------------------------------- On Dec. 3, 2014, 7:41 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28626/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Added basic DiskInfo check in master. > > > Diffs > ----- > > src/master/master.cpp 99b5a2042377481f933379cf35d4715f7d771efa > > Diff: https://reviews.apache.org/r/28626/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
