----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28664/#review63764 -----------------------------------------------------------
Ship it! This is only a partial check for duplicate IDs, can you add a TODO expressing that we need to check for duplicate IDs on the slave's existing tasks? If you do the testing cleanup, it would be easy to test the other interesting cases: (1) Duplicate ID across task + executor. (2) Duplicate ID within executor. Mind following up separately with the testing cleanup, and for now, drop a TODO for testing (1) and (2)? src/master/master.cpp <https://reviews.apache.org/r/28664/#comment106060> Per my comment above, can you add a TODO here? - Ben Mahler On Dec. 3, 2014, 7:38 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28664/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:38 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Added duplicated persistence id check in ResourceChecker. > > > Diffs > ----- > > src/master/master.cpp 99b5a2042377481f933379cf35d4715f7d771efa > src/tests/resource_offers_tests.cpp > c8c25d75d93b6e9e25d35cb9953f9c91dfbbbd14 > > Diff: https://reviews.apache.org/r/28664/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
