> On Dec. 3, 2014, 7:39 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/event_loop.hpp, line 23 > > <https://reviews.apache.org/r/28315/diff/4/?file=781851#file781851line23> > > > > Why the void pointer argument?
For now, since we are using pthreads, this is the prototype expected by pthread_create. http://man7.org/linux/man-pages/man3/pthread_create.3.html If in the future we move to std::thread this can look cleaner :-) > On Dec. 3, 2014, 7:39 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/src/libev.cpp, lines 87-89 > > <https://reviews.apache.org/r/28315/diff/4/?file=781852#file781852line87> > > > > Is this relevant? We are not testing on opensolaris and last time I did > > (end last year) it didn't work. I will get rid of it. If someone wants to put it back we can always look at the git history :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28315/#review63713 ----------------------------------------------------------- On Dec. 3, 2014, 7:09 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28315/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:09 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/clock.cpp dfe9ced2415b8567abb8c137ab73d90b59164d67 > 3rdparty/libprocess/src/event_loop.hpp PRE-CREATION > 3rdparty/libprocess/src/libev.cpp 8a557ce1d604f27fc1cc2ce601f1fc94f49d1ae6 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28315/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
