----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28467/#review63723 -----------------------------------------------------------
Ship it! Taken it's a code move 3rdparty/libprocess/src/poll_socket.cpp <https://reviews.apache.org/r/28467/#comment106009> This will probably break on Mac OS X - take a look in config.hpp for MSG_NOSIGNAL. Think you need to include it :-) - Niklas Nielsen On Dec. 3, 2014, 11:52 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28467/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 11:52 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28467/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
