> On Dec. 4, 2014, 6:28 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/Makefile.am, lines 67-68 > > <https://reviews.apache.org/r/28319/diff/4/?file=782096#file782096line67> > > > > Wierd alignment of slashes?
I tried to find a misalignment, but this is aligned with the other libprocess_la_SOURCES. The libprocess_la_CPPFLAGS are aligned at a different column, we can standardize this if you wish? > On Dec. 4, 2014, 6:28 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/configure.ac, line 576 > > <https://reviews.apache.org/r/28319/diff/4/?file=782097#file782097line576> > > > > Can we elaborate just a little bit here please? See the other examples, > > something like: > > > > You have requested to use libevent but no suitable libevent could be > > found. I used the pattern for libapr / libsvn in the most recent review. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28319/#review63871 ----------------------------------------------------------- On Dec. 5, 2014, 4:19 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28319/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 4:19 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > This flag will be used to distinguish between libev (default) and libevent. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa > 3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204 > 3rdparty/libprocess/src/process.cpp > 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3 > > Diff: https://reviews.apache.org/r/28319/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
