----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28721/#review64069 -----------------------------------------------------------
Ship it! I like the approach of checking the brew prefix. configure.ac <https://reviews.apache.org/r/28721/#comment106490> configure.ac <https://reviews.apache.org/r/28721/#comment106491> Mind that we might have users using macports. But then again, it has become a bit out-of-fashion and my bet is that most OSX users will try to use brew instead. Would be great if we tested for the availability of brew first or redirect any possible error to /dev/null just to make sure we dont confuse our users. - Till Toenshoff On Dec. 5, 2014, 9:53 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28721/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 9:53 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2113 > https://issues.apache.org/jira/browse/MESOS-2113 > > > Repository: mesos-git > > > Description > ------- > > Modify mesos configure.ac to set `$with_svn` to `brew --prefix subversion` > for OS X. Fixes MESOS-2113. > > > Diffs > ----- > > configure.ac 1ca6a6b3aa391275dda1b00de27e212c4fc8190f > > Diff: https://reviews.apache.org/r/28721/diff/ > > > Testing > ------- > > `../configure && make && make check` on Ubuntu and OS X > > > Thanks, > > Michael Park > >
