----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28814/#review64305 -----------------------------------------------------------
src/master/allocator.hpp <https://reviews.apache.org/r/28814/#comment106940> I am wondering whether we can take Deferred here (instead of function) to refect the fact that all offer callbacks need to be serialized. Looking at your following patch for tests refactor, the 'queue' you introduced is essentially simulating a libprocess Process. By using deferred, I guess you can also leverage many of the gtest/gmock utilities we built around libprocess Process (e.g., FUTURE_DISPATCH, etc.). - Jie Yu On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28814/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 10:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > The allocator currently stores a PID<Master> for communicating back to the > master. However, this makes unit testing impossible, instead we now take a > function object, which enables unit testing of the allocator. > > > Diffs > ----- > > src/master/allocator.hpp 0849ac8244b638523ecbadff79738ad4cadff5cb > src/master/hierarchical_allocator_process.hpp > f18346f435a16d1e6243315bffa00fabd164e310 > src/master/master.cpp b910665caa437f3f92c5abc14c0b8eab9a1ec5f3 > src/tests/mesos.hpp aa10343b7ca56d71697a8c83e7227c8362d07039 > > Diff: https://reviews.apache.org/r/28814/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
