-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28830/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-2172
https://issues.apache.org/jira/browse/MESOS-2172
Repository: mesos-git
Description
-------
Layed the groundwork for having a fetcher object with a cache dir per slave.
Factored all fetcher-relevant code into a fetcher class and process. Added a
fetcher parameter to a lot of methods related to launching tasks, mostly in
containerizers. The latter are thus not holders of fetchers, only slaves are.
Diffs
-----
src/slave/containerizer/composing.hpp
f1e60b0dae45757f3573c81a4a4a2de6fcb27aca
src/slave/containerizer/composing.cpp
a6ae817a973d49b433519beb8eda99692c203613
src/slave/containerizer/containerizer.hpp
02754cd5b4499d5809c80985100d11d2663dcc44
src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/slave/containerizer/external_containerizer.hpp
8363cec490a2918e08a8d30d9b8832fd1e2dd4f5
src/slave/containerizer/external_containerizer.cpp
efbc68f205b26cff58bc414427d3361711afcc94
src/slave/containerizer/fetcher.hpp 12b81b1065b6b0a0368ebd44326c75c1d4e4ba79
src/slave/containerizer/fetcher.cpp d702a9ccc15b21ba26fb9356aa69da15dfd5973e
src/slave/containerizer/mesos/containerizer.hpp
0b635d445f6cc5c188670ddadab98d4154fc5d2b
src/slave/containerizer/mesos/containerizer.cpp
d70259b10abdf995229ceba66ec9b58cf111e056
src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6
src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b
src/tests/composing_containerizer_tests.cpp
5ab5a36cadb7f8622bad0c5814e9a5fb338753ad
src/tests/containerizer.hpp 24b014f44d9eec56840e18cf39fbf9100f2c0711
src/tests/containerizer.cpp a17e1e0c3f4d5fb2e369ae2b06430b8fd366bfc7
src/tests/containerizer_tests.cpp 02a5f15ff970b475df2fe5e48f2aee42eeefe18e
src/tests/docker_containerizer_tests.cpp
bed2d1005647d62b3ec013315b883d33990b896e
src/tests/external_containerizer_test.cpp
45cdeb57dd5b7b20294ebdecfd091a77e86941cb
src/tests/fetcher_tests.cpp 9e48392d31c886bad60abc8999fe293f55f589b0
src/tests/isolator_tests.cpp 01c0239553011c68fecaeeeb1d87fc097509a136
src/tests/slave_recovery_tests.cpp 8bd0f145ff52d91cc0ad194e8676fb105aba2792
src/tests/slave_tests.cpp f2896a1fc4521452e29fd261a6f117372345dcfc
Diff: https://reviews.apache.org/r/28830/diff/
Testing
-------
make check on MacOS X 10.10 and Ubuntu 13.10.
Some of these tests fail on Linux when running "make check" as root, but not
always the same ones and they all seme unrelated:
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Override
[ FAILED ] DockerContainerizerTest.ROOT_DOCKER_Default_CMD_Args
[ FAILED ] ContainerizerTest.ROOT_CGROUPS_BalloonFramework
[ FAILED ] CgroupsAnyHierarchyTest.ROOT_CGROUPS_Tasks
[ FAILED ] CgroupsAnyHierarchyTest.ROOT_CGROUPS_Read
[ FAILED ] UserCgroupIsolatorTest/0.ROOT_CGROUPS_UserCgroup, where TypeParam
= mesos::internal::slave::CgroupsMemIsolatorProcess
[ FAILED ] UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup, where TypeParam
= mesos::internal::slave::CgroupsCpushareIsolatorProcess
[ FAILED ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup, where TypeParam
= mesos::internal::slave::CgroupsPerfEventIsolatorProcess
[ FAILED ] ContainerizerTest.ROOT_CGROUPS_BalloonFramework
[ FAILED ] NsTest.ROOT_setns
[ FAILED ] PerfTest.ROOT_SampleInit
Thanks,
Bernd Mathiske
