> On Dec. 5, 2014, 5:49 p.m., Niklas Nielsen wrote: > > src/hook/hook.hpp, line 36 > > <https://reviews.apache.org/r/28655/diff/1/?file=781773#file781773line36> > > > > Think a namespace reads better for task label vs environment decorator; > > that way we don't have to name it masterXXXXXXLabelDecorator vs > > masterXXXXXXEnvironmentDecorator > > > > What do you think?
I think namespaces add more complexity, at least right now. We can revisit the decision at a later time. > On Dec. 5, 2014, 5:49 p.m., Niklas Nielsen wrote: > > src/hook/manager.hpp, line 35 > > <https://reviews.apache.org/r/28655/diff/1/?file=781774#file781774line35> > > > > I don't understand this enum - can you expand on what you want to use > > it for? This will be more apparent once we have more than one hook/decorator. > On Dec. 5, 2014, 5:49 p.m., Niklas Nielsen wrote: > > src/hook/manager.hpp, line 38 > > <https://reviews.apache.org/r/28655/diff/1/?file=781774#file781774line38> > > > > NUM_HOOKS? Removed. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28655/#review63916 ----------------------------------------------------------- On Dec. 9, 2014, 5:20 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28655/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 5:20 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > This hook allows hook modules to add additional labels to the incoming > TaskInfo object. The labels are then read on the slave/executor side which > may then act upon them. > > TODOs before we commit: > 0. Split this RR to move Master specific code to a separate RR. > 1. Add a test hook module. > > > Diffs > ----- > > src/Makefile.am 86161fe7a8bdd86958d24adb74d434cd92d7dfb8 > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/master/flags.hpp 1cea50c02f3ad7de1e1ae91d65d1accdb9af7b03 > src/master/main.cpp 193d53f13d8b14638b311cc290b5a5802ea56299 > src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063 > src/module/hook.hpp PRE-CREATION > src/module/manager.cpp b15b0fc3f056fe29bd4d1acca508d75805ef2e0b > > Diff: https://reviews.apache.org/r/28655/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
