----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28871/#review64463 -----------------------------------------------------------
Ship it! Looks great now, thanks Jie! Curious if we could get away without EphemeralProcess, and intead have a Thunker that is terminated in the loop. If not, let's comment why we needed the EphemeralProcess as it seems not so obvious to me. 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/28871/#comment107186> Let's add a comment here as to why we need this thing, as opposed to just a simple Thunker process (which could be re-used in other benchmarks and terminated externally in this case). Is the internal termination important, or could it be done in the loop beside the spawn, seems a bit more obvious in the loop: ``` process::spawn(process); dispatch(process->self(), &Thunker::thunk, f); process::terminate(process->self(), false); ``` 3rdparty/libprocess/src/tests/benchmarks.cpp <https://reviews.apache.org/r/28871/#comment107181> include vector? Now that you've changed it, can we split them? ``` vector<LinkerProcess*> linkers; vector<ProcessBase*> linkees; ``` Or s/linkedProcesses/processes/ now that you've renamed it: ``` vector<ProcessBase*> processes; ``` - Ben Mahler On Dec. 9, 2014, 11:15 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28871/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 11:15 p.m.) > > > Review request for mesos, Ben Mahler and Joris Van Remoortere. > > > Bugs: MESOS-2182 > https://issues.apache.org/jira/browse/MESOS-2182 > > > Repository: mesos-git > > > Description > ------- > > Added a benchmark to test large number of links for MESOS-2182. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/benchmarks.cpp > 227b8e7ae5f855918073b7b3ea89d773a39aa8fa > > Diff: https://reviews.apache.org/r/28871/diff/ > > > Testing > ------- > > make check > ./benchmarks > > > Thanks, > > Jie Yu > >
