> On 12月 10, 2014, 5:30 p.m., Dominic Hamon wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, line 2649 > > <https://reviews.apache.org/r/28904/diff/1/?file=788206#file788206line2649> > > > > this will fail in bash as the \t will be literal.
Thank you for comment. Shebang line in generated script is #!/bin/sh, that the script is actually executed in a POSIX Mode. http://www.gnu.org/software/bash/manual/bashref.html#Bash-POSIX-Mode - Kiyonari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28904/#review64572 ----------------------------------------------------------- On 12月 10, 2014, 3:45 p.m., Kiyonari Harigae wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28904/ > ----------------------------------------------------------- > > (Updated 12月 10, 2014, 3:45 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > echo command in sh doesn't have options > > sh: echo: I/O error occurs, It is not possible to set the port range. > Also, echo in /bin/sh performs output a (horizontal) tab character > when encountered the escape sequence of \t. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.cpp > c6fff21903e546709a90b53690e02a75a4ca5262 > > Diff: https://reviews.apache.org/r/28904/diff/ > > > Testing > ------- > > > Thanks, > > Kiyonari Harigae > >
