----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28959/#review64777 -----------------------------------------------------------
3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28959/#comment107537> the 0 should be on the next line 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28959/#comment107538> you're in the process::network namespace, so you should be able to just use 'socket('. At the very least maybe just 'network::socket' would be clearer? I don't know.. what do you think? 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/28959/#comment107540> i know that we do this, but according to the letter of the style guide: "You may not use a using-directive to make all names from a namespace available." for very good reasons (it pollutes the global namespace). i'd like to avoid adding more instances of this. 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/28959/#comment107541> and you're explicitly scoping the call anyway, so you don't need the using namespace :) - Dominic Hamon On Dec. 11, 2014, 10:10 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28959/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 10:10 a.m.) > > > Review request for mesos, Ben Mahler and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Introduce process::network namespace to encapsulate socket call wrappers and > Socket class > > > Diffs > ----- > > 3rdparty/libprocess/include/process/event.hpp > 6392332d7bf63157d305868ac6bfe95c6921ddaa > 3rdparty/libprocess/include/process/socket.hpp > 91f9084984daa18d323f05946211bea90f94ae11 > 3rdparty/libprocess/src/decoder.hpp > b66f378b4ecbded9e091267e943e721bb153c290 > 3rdparty/libprocess/src/http.cpp 465e4473685a2e441401e454ad1e8c04db2a4e0a > 3rdparty/libprocess/src/process.cpp > 688aebd196ae954441a393c5b702db1b2036453c > 3rdparty/libprocess/src/tests/http_tests.cpp > 3bda76d4b4b958e956b4f5c248190c2fdfcd0d51 > 3rdparty/libprocess/src/tests/process_tests.cpp > 45be2e15d6f57db89ba7ab758d828ffce3be4b61 > > Diff: https://reviews.apache.org/r/28959/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
