> On Dec. 11, 2014, 7:27 p.m., Dominic Hamon wrote: > > src/linux/routing/link/link.cpp, line 159 > > <https://reviews.apache.org/r/28957/diff/1/?file=789532#file789532line159> > > > > while you're here, would you mind replacing '> >' with '>>'?
Thanks for that! Is it ok if I have replaced all the > > occurences from the files that I have already modified in this patch? I think it's better to get rid of them now. - Evelina ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28957/#review64775 ----------------------------------------------------------- On Dec. 11, 2014, 8:14 p.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28957/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 8:14 p.m.) > > > Review request for mesos, Ben Mahler and Dominic Hamon. > > > Repository: mesos-git > > > Description > ------- > > Fixed coding style issues related to the variable naming convention in the > routing library > > > Diffs > ----- > > src/linux/routing/diagnosis/diagnosis.cpp > d826ae240901eff1d49febacb287cebd6e6724c9 > src/linux/routing/filter/arp.cpp b794a735aaffa7e4679c51a3d05511c2403c2e93 > src/linux/routing/filter/icmp.cpp 12b9eb75135602ee6d4caa92ad7275f266d742eb > src/linux/routing/filter/internal.hpp > a970613ce1a9da76388a49caf5409ed73a457367 > src/linux/routing/filter/ip.cpp 74525a9e6be8c96cda0940011d7cd930876e0394 > src/linux/routing/internal.hpp 87a539b5d9e46671261b710281aff8aa82e315b4 > src/linux/routing/link/internal.hpp > 0d46e9a6901c79514bd83c27a89c83407f356578 > src/linux/routing/link/link.cpp a912122672833f2cc646706f0711220b35b9ac9f > src/linux/routing/queueing/ingress.cpp > e696950a39fb9da3dfa614c71a02e85e0e5096f1 > src/linux/routing/queueing/internal.hpp > 4d8bd55096df9192e5656c899c537ac3bd45b7d9 > src/linux/routing/route.cpp 80860346066b67a33f6ec75e961391e07f89e500 > > Diff: https://reviews.apache.org/r/28957/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
