> On Dec. 9, 2014, 12:09 a.m., Jie Yu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 326 > > <https://reviews.apache.org/r/28816/diff/1/?file=785783#file785783line326> > > > > This is a bit hacky. Can we do > > > > allocation.get().resources.get(slave1.id()).get()
Thanks! Removed the include for this as well. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28816/#review64319 ----------------------------------------------------------- On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28816/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 10:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > This moves DRFAllocatorTest.PerSlaveAllocation into a > HierarchicalAllocatorTest.CoarseGrained unit test. > > Note that reviewboard cannot display the removal of > DRFAllocatorTest.PerSlaveAllocation, because the file was renamed in an > earlier review in the chain. See the raw diff. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp PRE-CREATION > src/tests/master_allocator_tests.cpp > ea78893b1fa78da5cbdbabf1b4992910fe62b67c > > Diff: https://reviews.apache.org/r/28816/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
