> On Dec. 9, 2014, 1:27 a.m., Jie Yu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 513 > > <https://reviews.apache.org/r/28819/diff/1/?file=785789#file785789line513> > > > > This doesn't seem to be correct. Shouldn't it be ```extract("*")```? > > Copy paste error?
Gah, thank you Jie!! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28819/#review64325 ----------------------------------------------------------- On Dec. 8, 2014, 10:10 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28819/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 10:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > This moves ReservationAllocatorTest.ResourcesReturned into a > HierarchicalAllocatorTest.Reservations unit test. > > Note that reviewboard cannot display the removal of > ReservationAllocatorTest.ReservedResources, because the file was renamed in > an earlier review in the chain. See the raw diff. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp PRE-CREATION > src/tests/master_allocator_tests.cpp > 77ae0bed1ff42eb5a1bbda40030d2d8ea0487bd7 > > Diff: https://reviews.apache.org/r/28819/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
