> On Dec. 12, 2014, 6:31 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp, lines 99-110 > > <https://reviews.apache.org/r/28983/diff/1/?file=790035#file790035line99> > > > > Ditto Dominic's comment. You probably wanna at least add a CHECK here.
Will go with ABORT since we don't want to leak the google logging dependency throughout stout (see error handling in Try, Option, etc). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28983/#review64946 ----------------------------------------------------------- On Dec. 12, 2014, 7:21 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28983/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 7:21 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > Discovered these were missing when trying to unit test the allocator. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp > 72dea4d27ae57ab924de9afc3ce6b154618a54fd > > Diff: https://reviews.apache.org/r/28983/diff/ > > > Testing > ------- > > make check > > Added tests in the subsequent review. > > > Thanks, > > Ben Mahler > >
