----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29128/#review65269 -----------------------------------------------------------
Ship it! src/tests/resources_tests.cpp <https://reviews.apache.org/r/29128/#comment108352> Looks like you can use EXPECT_SOME_EQ to avoid the separate statements? - Ben Mahler On Dec. 17, 2014, 1:10 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29128/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 1:10 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > See summary. Seprated out from https://reviews.apache.org/r/28720/ > > > Diffs > ----- > > include/mesos/resources.hpp 296553a > src/common/resources.cpp 9bf7ae9 > src/tests/resources_tests.cpp bac092e > > Diff: https://reviews.apache.org/r/29128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
