> On Dec. 18, 2014, 12:18 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1988-1994 > > <https://reviews.apache.org/r/29178/diff/1/?file=795164#file795164line1988> > > > > What about: > > > > ``` > > } else if (resource.disk().has_volume()) { > > return Error("Non-persistent disk volume is not supported"); > > } else { > > return Error("DiskInfo is set but empty"); > > } > > ```
Much nicer! - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29178/#review65399 ----------------------------------------------------------- On Dec. 17, 2014, 8:30 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29178/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 8:30 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Disallowed empty DiskInfo. > > > Diffs > ----- > > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > > Diff: https://reviews.apache.org/r/29178/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
