> On Dec. 18, 2014, 6:33 p.m., Ben Mahler wrote: > > docs/configuration.md, line 571 > > <https://reviews.apache.org/r/29219/diff/2/?file=796673#file796673line571> > > > > Thanks Kapil! > > > > Would love to see a mention of why one would use this flag (although > > such a note likely belongs in the flags.hpp file as well), especially on > > the network monitoring page: > > http://mesos.apache.org/documentation/latest/network-monitoring/ > > > > We introduced this because the network monitoring / isolation technique > > imposes an implicit resource acquisition on each executor (# ephemeral > > ports), as a result you can only run a certain number of executors on each > > slave. > > > > This flag was added as a hack to avoid frameworks getting offers when > > we've allocated all of the ephemeral port range on the slave. > > > > Feel free to make such changes separately. :)
Done. I have created a separate RR (https://reviews.apache.org/r/29227/) to update flags.hpp. The wording is mostly yours :-). - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29219/#review65562 ----------------------------------------------------------- On Dec. 18, 2014, 7:56 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29219/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2014, 7:56 p.m.) > > > Review request for mesos, Till Toenshoff and Timothy Chen. > > > Repository: mesos-git > > > Description > ------- > > These flags are visible only when configured with --with-network-isolator > flag. > > > Diffs > ----- > > docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa > > Diff: https://reviews.apache.org/r/29219/diff/ > > > Testing > ------- > > Checked on github at > https://github.com/karya0/mesos/blob/hooks/docs/configuration.md > > > Thanks, > > Kapil Arya > >
