----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28723/#review65577 -----------------------------------------------------------
Ship it! I'm ok with 'persisted_resources' as a name, considering that both "persistent disk" and "persistent role" (a.k.a. dynamic reservation) resources all fall under the category of resources that are persistent/durable/sticky/etc. If it turns out that we find a better name when dynamic reservations enter the picture, we can safely change the name as long as the tag number remains the same. src/messages/messages.proto <https://reviews.apache.org/r/28723/#comment108823> Per our discussion, we should probably call out that these are resources that must be explicitly released by the framework. src/messages/messages.proto <https://reviews.apache.org/r/28723/#comment108825> Let's add a comment that this is sent to the slave whenever there is an acquisition or release of a persistent resource (and we probably need to piggy-back it on (re-)registration too? Maybe a TODO in this patch?) - Ben Mahler On Dec. 4, 2014, 10:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28723/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2014, 10:56 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2100 > https://issues.apache.org/jira/browse/MESOS-2100 > > > Repository: mesos-git > > > Description > ------- > > Added protobuf protocol for communicating persisted resources between master > and slave. > > > Diffs > ----- > > src/messages/messages.proto 28e593f338a154892b1cdf398710bb44e3f9f119 > > Diff: https://reviews.apache.org/r/28723/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
