----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28781/#review65702 -----------------------------------------------------------
It looks like this patch will change when we make the Resource::Operations explicit. For example, we probably will have an explicit modification of persistent resources on the slave, instead of inferring inside addTask, addExecutor. Thoughts? Will you be updating this one to reflect the API change? src/master/master.hpp <https://reviews.apache.org/r/28781/#comment108913> Looks like we may want a way to pull out persisted '`Resources`' from general '`Resources`'. Feel free to leave a TODO for now. src/master/master.hpp <https://reviews.apache.org/r/28781/#comment108911> How about: ``` // Resources that should be persisted by the slave (e.g. persistent disk, // dynamic reservation, etc). These are either in use by a task/executor, // or are available for use and will be re-offered to the framework. ``` src/master/master.hpp <https://reviews.apache.org/r/28781/#comment108908> s/persistent/persisted/ src/master/master.cpp <https://reviews.apache.org/r/28781/#comment108907> Ditto here. Also, we need to ensure that we don't launch tasks with operations on old slaves. Once Operations are explicit, that should be pretty easy to enforce, yes? Probably belongs in a separate patch. src/master/master.cpp <https://reviews.apache.org/r/28781/#comment108906> Mind adding a NOTE here that we always send the message, since slaves < 0.22.0 will drop it silently and that's ok? Alternatively, you can use the version: ``` if (slave.version.isSome() && slave.version.get() >= Version(0, 22, 0)) { ... } ``` You may want to punt with a TODO since we currently store a plain std::string. This was because Version doesn't yet support labels and build metadata. - Ben Mahler On Dec. 10, 2014, 2 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28781/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 2 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2030 > https://issues.apache.org/jira/browse/MESOS-2030 > > > Repository: mesos-git > > > Description > ------- > > Maintained persisted resources in master memory. > > > Diffs > ----- > > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/master.cpp 1cf2074b78e260bcccf96f4383bc4747b1e75063 > > Diff: https://reviews.apache.org/r/28781/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
