----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29174/#review65752 -----------------------------------------------------------
src/master/allocator.hpp <https://reviews.apache.org/r/29174/#comment108991> Shouldn't this take the reservation type? What if we want to modify static reservations for the "master reservations" feature? And SlaveID could be optional in the case of "offer reservations" And what about reserving resources for a role but not a specific framework? Or a multi-role framework that wants to reserve for a specific role? The allocator's reservation API deserves a proper design iteration. Alex is also working on modularizing the allocator, so we really want to solidify the API. src/master/hierarchical_allocator_process.hpp <https://reviews.apache.org/r/29174/#comment108993> Returning an error seems appropriate. The master can decide whether to ignore it - Adam B On Dec. 17, 2014, 3:37 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29174/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 3:37 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Update the master and allocator + Added a test for acquiring dynamic > reservations. > > > Diffs > ----- > > src/master/allocator.hpp f4068aad42a7df38544718dcd171ff239dc1e39a > src/master/hierarchical_allocator_process.hpp > 95fa520a3947474472cd36987c2342e1bfb51cfe > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/master.cpp 0f55a5cc2d6845cbaace718a48f771d80aad0e6e > src/tests/master_allocator_tests.cpp > 0e2e5b551ce026d630fe8f9ebf85c71384d8f43f > src/tests/mesos.hpp bb24222c20cb5458b5c627d2001fc3cb1e542cce > > Diff: https://reviews.apache.org/r/29174/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
