----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28809/#review65755 -----------------------------------------------------------
src/slave/slave.cpp <https://reviews.apache.org/r/28809/#comment108998> What is the source of truth for persistent resources? The checkpoint or the master? What if a framework is trying to launch a task on a slave with a new persistent disk resource, while at the same time, the slave is restarted with new persistent disks added by the slave operator? Assume we can update slave resources without invalidating the SlaveID, and that the master has already started processing the launchTask when the slave tries to reregister. I'm guessing the slave would reject the UpdateResources call until the slave has successfully re-registered with the master, so the master would have the updated persistentResource, which it would then update with the newly launched task's persistent disk. - Adam B On Dec. 8, 2014, 2:19 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28809/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 2:19 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos-git > > > Description > ------- > > Started to maintain and checkpoint persisted resource in slave. That includes: > 1) responds to update resources message > 2) checkpoint resources > 3) recover checkpointed resources > 4) send checkpointed resources during register/reregister > > > Diffs > ----- > > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp 9ac64589c353b2f17f538db7de01faa55b2369b9 > > Diff: https://reviews.apache.org/r/28809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
