----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29380/#review65977 -----------------------------------------------------------
Patch looks great! Reviews applied: [29274, 29380] All tests passed. - Mesos ReviewBot On Dec. 23, 2014, 10:04 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29380/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 10:04 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to > 'mcypark', and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added resource operations to the launchTasks API. > > See details in > https://reviews.apache.org/r/29173/ > > The reason for introducing resource operations while launching task is to > allow frameworks to transform the offered resources for persistent disk and > dynamic reservation. We want the framework to explicitly set them so that it > causes less confusion to the master (master no long needs to infer resource > transformations which sometimes are ambiguate). > > > Diffs > ----- > > include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e > include/mesos/scheduler/scheduler.proto > 5491c59e7addda0ee5d95a019d7eaeb953ca82e4 > src/master/master.hpp 26116aff1e965501c8d94ea0b5bd1be37f944887 > src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd > src/messages/messages.proto 16043dd934cbfc1159dad7adf366dfbfcc5a077b > src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > > Diff: https://reviews.apache.org/r/29380/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
