----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29274/#review65982 -----------------------------------------------------------
I'm not sure I buy into the before/after Operation style. Is there any previous discussion of alternatives (in a JIRA)? include/mesos/mesos.proto <https://reviews.apache.org/r/29274/#comment109288> What about a declarative model: current vs. desired? include/mesos/mesos.proto <https://reviews.apache.org/r/29274/#comment109297> s/Operation/Action/? Or `Transformation` like you had before? include/mesos/mesos.proto <https://reviews.apache.org/r/29274/#comment109290> Is there going to have to be complex verification? What happens if I specify a non-disk resource in before but not after, for a disk-related operation? What if a `before` resource doesn't actually exist? A declarative approach where one only specifies (an action and) the desired outcome would allow the recipient (master) to do whatever is necessary to reach the desired outcome. include/mesos/mesos.proto <https://reviews.apache.org/r/29274/#comment109287> So, `Resource` contains an `Operation` which contains repeated `Resource`s? But there is no actual Operation field on Resource. Looks like ACL is currently the only message that has submessages that aren't used by fields of the parent message. Perhaps Operation should be a top-level message instead? What about Operations on things besides resources? - Adam B On Dec. 23, 2014, 2:04 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29274/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 2:04 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, switched to > 'mcypark', and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Added Resource::Operation to mesos.proto per our discussion in > https://reviews.apache.org/r/29173/ > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > > Diff: https://reviews.apache.org/r/29274/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
