----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28671/#review66115 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/socket.hpp <https://reviews.apache.org/r/28671/#comment109473> Let's not include the livevent implementaition until we actually commit it. 3rdparty/libprocess/src/socket.cpp <https://reviews.apache.org/r/28671/#comment109474> Let's make this a factory function on PollSocketImpl itself (e.g., PollSocketImpl::create), and expose the PollSocketImpl declaration in poll_socket.hpp. - Benjamin Hindman On Dec. 19, 2014, 7:57 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28671/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 7:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Bugs: MESOS-2109 > https://issues.apache.org/jira/browse/MESOS-2109 > > > Repository: mesos-git > > > Description > ------- > > Virtualize Socket Implementation interface. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 7e1e3f22583f44a9aea8259bafedc2877ad2e633 > 3rdparty/libprocess/src/poll_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/socket.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/28671/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
