----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29290/#review66339 -----------------------------------------------------------
Bad patch! Reviews applied: [29288, 29289, 29290] Failed command: ./support/apply-review.sh -n -r 29290 Error: 2014-12-30 05:28:02 URL:https://reviews.apache.org/r/29290/diff/raw/ [24147/24147] -> "29290.patch" [1] error: patch failed: src/common/protobuf_utils.hpp:21 error: src/common/protobuf_utils.hpp: patch does not apply error: patch failed: src/common/protobuf_utils.cpp:110 error: src/common/protobuf_utils.cpp: patch does not apply error: patch failed: src/linux/routing/diagnosis/diagnosis.cpp:41 error: src/linux/routing/diagnosis/diagnosis.cpp: patch does not apply error: patch failed: src/linux/routing/filter/icmp.cpp:105 error: src/linux/routing/filter/icmp.cpp: patch does not apply error: patch failed: src/linux/routing/filter/ip.cpp:159 error: src/linux/routing/filter/ip.cpp: patch does not apply error: patch failed: src/linux/routing/route.cpp:83 error: src/linux/routing/route.cpp: patch does not apply error: patch failed: src/master/http.cpp:350 error: src/master/http.cpp: patch does not apply error: patch failed: src/master/master.cpp:229 error: src/master/master.cpp: patch does not apply error: patch failed: src/sched/sched.cpp:1135 error: src/sched/sched.cpp: patch does not apply error: patch failed: src/scheduler/scheduler.cpp:127 error: src/scheduler/scheduler.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:958 error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply error: patch failed: src/slave/slave.cpp:169 error: src/slave/slave.cpp: patch does not apply error: patch failed: src/tests/master_contender_detector_tests.cpp:130 error: src/tests/master_contender_detector_tests.cpp: patch does not apply error: patch failed: src/tests/master_tests.cpp:966 error: src/tests/master_tests.cpp: patch does not apply error: patch failed: src/tests/port_mapping_tests.cpp:189 error: src/tests/port_mapping_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Dec. 30, 2014, 5:21 a.m., Evelina Dumitrescu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29290/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 5:21 a.m.) > > > Review request for mesos and Dominic Hamon. > > > Bugs: MESOS-1919 > https://issues.apache.org/jira/browse/MESOS-1919 > > > Repository: mesos-git > > > Description > ------- > > Created the inner class Address encapsulated inside the IP class. > The class uses a union with the in_addr and in6_addr fields. > I considered that the The MasterInfo protobuffers should have both an ipv4 > and an ipv6 field. > I intend to use the same Classifiers, addition, removal and update of > container filters, but write different encode/decode functions for IPv4/ICMP > and IPv6/ICMPv6 because the processing of the protocol headers differ. > > > Diffs > ----- > > src/common/protobuf_utils.hpp e42aaa57c0c0c1b8ece80b8ecac8a10ac9e832c3 > src/common/protobuf_utils.cpp 8ab5cdd80ecd499cb353141c1eaedaeb2a8b8b74 > src/linux/routing/diagnosis/diagnosis.cpp > 136ba379efbbe4200c0e9f794a2966ffee174fff > src/linux/routing/filter/icmp.cpp 86bd67b71a590b88344adbe10fd1b44ea1b5148d > src/linux/routing/filter/ip.cpp 922a732c3543a072674208b123fdfadbef2b15f2 > src/linux/routing/route.cpp b0eda7b662eca0ba1357e558f6f6b1474067b06d > src/master/http.cpp 46890bed05d7c4b63e1f7be5bb35217173e0ade8 > src/master/master.cpp d6651e299ddb73bfdc1b126c474075db6cda8acd > src/sched/sched.cpp 4be08f12e126ac192a5247ec426a36610bb021d1 > src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e > src/slave/containerizer/isolators/network/port_mapping.cpp > 2d813369bd844ad743f7d3f18dbab29b2467f2c8 > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > src/tests/master_contender_detector_tests.cpp > d847a30d21b2a2980c6b7ceb62bbf61dc77487de > src/tests/master_tests.cpp 7f796be085bc0692f1412cec57468fe1ab0ee894 > src/tests/port_mapping_tests.cpp eb82993520f7e8de46cf6cf6b638a9286aa9b3df > > Diff: https://reviews.apache.org/r/29290/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Evelina Dumitrescu > >
