----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28697/#review66449 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment110011> I like the concise form. Now let's name each: ("*", STATIC) - Unreserved (R, STATIC) - Statically Reserved (R, DYNAMIC) - Dynamically Reserved As an aside, why do we even care what `reservation_type` is set to when `role`=="*"? If we just ignore it, then all states are "valid". include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment110012> Reworded with the terms defined above: Reservation: ("*", STATIC) => (R, DYNAMIC) "An unreserved resource can become dynamically reserved for a role R." Unreservation: (R, DYNAMIC) => ("*", STATIC) "A dynamically reserved resource can become unreserved." The implied disallowed transitions: "Static reservations cannot be set or changed by a framework. These are set by a cluster administrator on slave start." include/mesos/mesos.proto <https://reviews.apache.org/r/28697/#comment110010> Excellent explanation, but this belongs in the design doc, not here. The framework author doesn't need API documentation that explains what cannot be done yet. Remove this whole Note 2 block. - Adam B On Dec. 30, 2014, 12:42 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28697/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 12:42 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, and > Vinod Kone. > > > Bugs: MESOS-2137 > https://issues.apache.org/jira/browse/MESOS-2137 > > > Repository: mesos-git > > > Description > ------- > > Adding new protobuf messages necessary to support dynamic reservations. > > > Diffs > ----- > > include/mesos/mesos.proto 540071db64961466eb75c779b3ea6863f4594437 > > Diff: https://reviews.apache.org/r/28697/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Michael Park > >
