----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28218/#review66670 -----------------------------------------------------------
Ship it! Sorry about the delay, Tim! Please update it and get it committed! Thanks! src/log/log.cpp <https://reviews.apache.org/r/28218/#comment110244> s/Log process/Log/ src/log/log.cpp <https://reviews.apache.org/r/28218/#comment110245> Ditto. src/log/recover.cpp <https://reviews.apache.org/r/28218/#comment110248> "Broadcasting recover request to all replicas" src/log/recover.cpp <https://reviews.apache.org/r/28218/#comment110249> "Log recovery timed out waiting for responses, retrying"; src/log/recover.cpp <https://reviews.apache.org/r/28218/#comment110251> "..., retrying in " << stringify(d); - Jie Yu On Dec. 24, 2014, 10:09 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28218/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 10:09 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > There has a quite few cases where we see a timed out fetch when master is > first launched, and I think there isn't enough logging to shed some lights > besides the failed to fetch after x minutes log line. > This rb adds more logging into replicated log recovery. > Not meant for merging yet, posting here for reviews and discuss places we > like to add more logging. > Review: https://reviews.apache.org/r/28218 > > > Diffs > ----- > > src/log/log.cpp b3c6c20d734ea82d8531217d53decf1707183565 > src/log/recover.cpp 26140654fda5011e89d0081e916a88c9681cd783 > src/log/replica.cpp c18de86f2659b848b0e8f0468e4efa820d048970 > src/state/log.cpp c0c81d551f465534daeaf03f18c0baa4c19754e6 > > Diff: https://reviews.apache.org/r/28218/diff/ > > > Testing > ------- > > make > > > Thanks, > > Timothy Chen > >
