> On Jan. 5, 2015, 11:57 a.m., Cody Maloney wrote: > > Did you make sure that the stout tests are built as well as the librocess > > tests with testing? > > > > The changes look visually good, I haven't verified locally they work yet > > though.
Yes, it does the correct thing and I verified it locally. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/#review66659 ----------------------------------------------------------- On Jan. 2, 2015, 7:15 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29550/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2015, 7:15 p.m.) > > > Review request for mesos and Cody Maloney. > > > Repository: mesos-git > > > Description > ------- > > 'make check' allows one to build and run the test suite. However, > 'make tests' allows one to build the test suite without running it. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 85170a11f049cda92840c52dc5acf447ca0a50fb > 3rdparty/libprocess/Makefile.am 6ab9cb8100163272126d533df47afac612769b76 > 3rdparty/libprocess/configure.ac 19bc601247f3b1fc6b28d3474fb39f7369bb382f > > Diff: https://reviews.apache.org/r/29550/diff/ > > > Testing > ------- > > Ran make tests. > > For added test, ran "make clean; make; make tests" followed by "make check" > and verified that no additional target are build in the "make check" step. > > > Thanks, > > Kapil Arya > >
