> On Jan. 5, 2015, 5:49 p.m., Timothy Chen wrote: > > src/hook/manager.cpp, line 124 > > <https://reviews.apache.org/r/28875/diff/3/?file=803964#file803964line124> > > > > This should never happen right? CHECK instead?
This can happen, if non of the hook modules install a remove-executor hook. This is true for other hooks as well. - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28875/#review66741 ----------------------------------------------------------- On Jan. 5, 2015, 5:42 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28875/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 5:42 p.m.) > > > Review request for mesos and Niklas Nielsen. > > > Bugs: MESOS-2060 > https://issues.apache.org/jira/browse/MESOS-2060 > > > Repository: mesos-git > > > Description > ------- > > This is different from decorators in the sense that it doesn't return > anything. > > > Diffs > ----- > > src/hook/hook.hpp PRE-CREATION > src/hook/manager.hpp PRE-CREATION > src/hook/manager.cpp PRE-CREATION > src/slave/slave.cpp 50b57819b55bdcdb9f49f20648199badc4d3f37b > > Diff: https://reviews.apache.org/r/28875/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
