----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29602/#review66760 -----------------------------------------------------------
Patch looks great! Reviews applied: [29595, 29596, 29597, 29598, 29599, 29600, 29601, 29602] All tests passed. - Mesos ReviewBot On Jan. 5, 2015, 11:27 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29602/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 11:27 p.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos-git > > > Description > ------- > > [5/9] Build Mesos Modules outside Mesos source tree. > > This allows us to avoid using "mesos::internal::slave" namespace when > building isolator module. > > > Diffs > ----- > > src/examples/test_isolator_module.cpp > dc107a1315271b0275c60819c4b5aaa1f527e73c > src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 > src/slave/containerizer/isolator.hpp > e82a14201f734292a46b8816c894fa8c766dae5a > src/slave/containerizer/isolator.cpp > 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 > src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 > src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 > > Diff: https://reviews.apache.org/r/29602/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
